Pass in cts_config to ZeroKMSConfigBuilder in EncryptedTable::init_headless
#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it_headless` This change updates `EncryptedTable::init_headless` to build its own `CtsConfig` and pass it into `ZeroKMSConfigBuilder`. By default, `ZeroKMSConfigBuilder` will build its own `CtsConfig` without environment variable overrides. Using `CtsConfig::builder().with_env()` and passing that to `ZeroKMSConfigBuilder` allows for overriding CTS config from environment variables.
coderdan
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates
EncryptedTable::init_headlessto build its ownCtsConfigand pass it intoZeroKMSConfigBuilder. By default,ZeroKMSConfigBuilderwill build its ownCtsConfigwithout environment variable overrides. UsingCtsConfig::builder().with_env()and passing that toZeroKMSConfigBuilderallows for overriding CTS config from environment variables.Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.