fix: config functions remove process #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auxesis
approved these changes
Jul 15, 2025
|
|
||
| -- Step 4: Verify configuration | ||
| SELECT * FROM eql_v2.config(); | ||
| ``` |
There was a problem hiding this comment.
We should add a step 5 to show a successful query of the encrypted_email column.
There was a problem hiding this comment.
Want to keep this section focused on config with EQL
Comment on lines
+389
to
+402
| - `eql_v2.add_column(table_name, column_name, cast_as DEFAULT 'text', migrating DEFAULT false)` - Add a new encrypted column | ||
| - `eql_v2.remove_column(table_name, column_name, migrating DEFAULT false)` - Remove an encrypted column completely | ||
|
|
||
| **Index Management:** | ||
| - `eql_v2.add_search_config(table_name, column_name, index_name, cast_as DEFAULT 'text', opts DEFAULT '{}', migrating DEFAULT false)` - Add a search index to a column | ||
| - `eql_v2.remove_search_config(table_name, column_name, index_name, migrating DEFAULT false)` - Remove a specific search index (preserves column configuration) | ||
| - `eql_v2.modify_search_config(table_name, column_name, index_name, cast_as DEFAULT 'text', opts DEFAULT '{}', migrating DEFAULT false)` - Modify an existing search index | ||
|
|
||
| **Configuration Management:** | ||
| - `eql_v2.migrate_config()` - Manually migrate pending configuration to encrypting state | ||
| - `eql_v2.activate_config()` - Manually activate encrypting configuration | ||
| - `eql_v2.discard()` - Discard pending configuration changes | ||
| - `eql_v2.config()` - View current configuration in tabular format (returns a table with columns: state, relation, col_name, decrypts_as, indexes) |
There was a problem hiding this comment.
This is a nice way of denoting which functions do what.
Co-authored-by: Lindsay Holmwood <[email protected]>
Co-authored-by: Lindsay Holmwood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues with EQL configuration remove functions and updates documentation to match current behavior.
Issues Fixed
tablesand properly handle missingcast_asfieldsmigratingparameter and clarified behavioral differencesBreaking Changes
None - remove is now working as expected