Drop operators more good #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderdan
reviewed
Jan 25, 2025
coderdan
reviewed
Jan 25, 2025
sql/017-operators-ore.sql
Outdated
|
|
||
| CREATE FUNCTION cs_encrypted_ore_64_8_compare(a cs_encrypted_v1, b jsonb) | ||
| RETURNS integer AS $$ | ||
| DECLARE |
There was a problem hiding this comment.
Nit but isn't DECLARE redundant when there are no variable to declare?
coderdan
approved these changes
Jan 25, 2025
tobyhede
force-pushed
the
fix-operators
branch
from
70ce420 to
de92465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and do other things more good too.
Operators need to be dropped early, so appending drops to the file.
Testing SQL is hard.