feat: ✨ add JSON and INT data types and update FFI to v0.18.0 #190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add searchableJson() method to schema for JSON field indexing - Update @cipherstash/protect-ffi from 0.16.0 to 0.17.0 - Refactor type system: EncryptedPayload → Encrypted, add JsPlaintext - Add comprehensive test suites for JSON, integer, and basic encryption - Update encryption format to use 'k' property for searchable JSON - Remove deprecated search terms tests for JSON fields - Simplify schema data types to text, int, jsonb only - Update model helpers to handle new encryption format - Fix type safety issues in bulk operations and model encryption
… EncryptedPayload - Replace EncryptedPayload imports with Encrypted type across all DynamoDB operations - Update EQL payload structure in toItemWithEqlPayloads helper function - Simplify payload structure by removing unused fields (bf, hm, ob) - Update type annotations in decrypt operations and bulk operations - Add TODO comment for future ste_vec EQL type support
- Remove empty test suite that was causing 'No test found' error - Remove unused test variable - Add comment placeholder for future tests - Keep boilerplate setup for when tests are needed
- Add searchable JSON column support with ste_vec indexes - Update toItemWithEqlPayloads to construct proper EQL payloads for JSON types - Handle both standard ciphertext (ct) and searchable vector (sv) payloads - Pass ProtectTable schema to helpers for column metadata access - Add comprehensive test coverage for JSON and nested JSON encryption - Support nested protectNestedJson values in test data
- Add comment noting need to implement new Encrypt payload type - Reminder to update when FFI interface is updated for sv payloads
coderdan
requested changes
Oct 7, 2025
Comment on lines
+11
to
+14
| metadata: { | ||
| count: csValue('metadata.count').dataType('int'), | ||
| level: csValue('metadata.level').dataType('int'), | ||
| }, |
There was a problem hiding this comment.
Is the plan to store this as a JSON instead of nested scalars?
There was a problem hiding this comment.
It's up to the customer - one of our customers (which I will not name here) helped define this interface from a direct use case.
| value: '42', | ||
| column: users.age, | ||
| table: users, | ||
| returnType: 'composite-literal' as const, |
There was a problem hiding this comment.
What is the composite literal for here?
There was a problem hiding this comment.
Refer to above: searches
| value: '99', | ||
| column: users.score, | ||
| table: users, | ||
| returnType: 'escaped-composite-literal' as const, |
There was a problem hiding this comment.
What is the escaped composite literal type?
There was a problem hiding this comment.
Refer to above: searches
| createdAt?: Date | ||
| updatedAt?: Date | ||
| address?: string | null | ||
| json?: Record<string, unknown> | null |
There was a problem hiding this comment.
I think the | null is redundant because you have made the field itself optional.
feat(protect): init ffi 18 pre release
calvinbrewer
changed the title
Revert "feat(protect): init ffi 18 pre release"
calvinbrewer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.