feat: Support ORE column usage in GROUP BY #206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`AsNodeKey` replaces `Semantic` from `sqltk`.
1. `Expr::Value` in projection columns will be resolved to `NativeValue` if they are unconstained (i.e. not used elsewhere in a manner that would contrain their type). 2. Standalone literals like the `true` in `SELECT * FROM tbl WHERE true;` will also be resolved to `Native`
`ValueTracker` keeps a reference to all of the `Expr::Value` types encountered during AST traversal and provides an API that other visitor pipeline states can interrogate. It is used to implement the automatic resolution of projection columns whose type would be unresolved if their type was unused in the statement. Unresolved type variables in projection columns can safely be resolved to `Native` if there is an `Expr::Value` node in the AST with the same type variable.
A function which is not a known EQL function will always be typed as returning `NativeValue(None)`. There is simply no way for `TypeInferencer` to know whether a function returns the same native type as its argument. The test previously worked because the `InferType` impl for `Function` was calling `self.unify_nodes(function, expr)` (where `expr` was the argument to the function). I'd noticed that it was incorrect but the test was not correspondingly updated.
tobyhede
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ORE column usage in GROUP BY
My first pass mad the Transformer impl incredibly messy and opaque. I ended up factoring out the transformations into seperate rules.
Acknowledgment
By submitting this pull request, I confirm that CipherStash can use, modify, copy, and redistribute this contribution, under the terms of CipherStash's choice.