fix: pin tests to Postgres 17 #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using images tagged `postgres:latest`, which was pointing to the latest release in the Postgres 17 series. Postgres 18 was released in the last 24 hours, and `postgres:latest` now points to Postgres 18. There seem to be some changes in the Postgres 18 containers, and volume mounting now breaks consistently in CI and locally. For now we will pin to Postgres 17, and look at supporting Postgres 18 later.
So we have continuous feedback on any breakages in the Postgres 17 release series.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a compatibility issue caused by the recent release of Postgres 18 by pinning the Postgres Docker image to version 17. The change prevents CI and local development environments from breaking due to volume mounting issues in the new Postgres 18 containers.
- Pin Postgres Docker image from
latestto version17in both compose files - Add
pull_policy: alwaysto ensure consistent image retrieval
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/docker-compose.yml | Updates test environment to use Postgres 17 with explicit pull policy |
| docker-compose.yml | Updates main development environment to use Postgres 17 with explicit pull policy |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CDThomas
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously Proxy's test harness was using images tagged
postgres:latest, which was pointing to the latest release in the Postgres 17 series.Postgres 18 was released in the last 24 hours, and
postgres:latestnow points to Postgres 18.There seem to be some changes in the Postgres 18 containers, and volume mounting now breaks consistently in CI and locally.
For now we will pin the test harness to Postgres 17, and look at supporting Postgres 18 in a subsequent PR.
Acknowledgment
By submitting this pull request, I confirm that CipherStash can use, modify, copy, and redistribute this contribution, under the terms of CipherStash's choice.