Misc cleanups #34
Merged
Misc cleanups #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
freshtonic
commented
Dec 10, 2024
freshtonic
commented
- Fix clippy errors, except for dead code warnings which have been allowed for now while we are at this stage of development.
- Formatting
auxesis
requested changes
Dec 10, 2024
Contributor
auxesis
left a comment
auxesis
left a comment
There was a problem hiding this comment.
Big fan of these clean ups, thanks @freshtonic.
One change needed, otherwise good to merge.
.gitignore
Outdated
Contributor
There was a problem hiding this comment.
We definitely need to change this back, otherwise files like ./packages/cipherstash-proxy/tests/config/cipherstash-proxy.toml won't be included in the repo, and all tests will break.
Suggested change
| cipherstash-proxy.toml | |
| ./cipherstash-proxy.toml |
Contributor
Author
There was a problem hiding this comment.
Right - in that case it should be /cipherstash-proxy.toml because ./cipherstash-proxy.toml does not work (it does not ignore it)
freshtonic
force-pushed
the
misc-cleanups
branch
from
7d8f254 to
147c923
Compare
auxesis
approved these changes
Dec 10, 2024
Contributor
auxesis
left a comment
auxesis
left a comment
There was a problem hiding this comment.
LGTM, thanks @freshtonic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.