Skip to content

Fix flaky test: TestO11y/http_with_token #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix flaky test: TestO11y/http_with_token #1248

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions o11y/otel/otel_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,16 @@ func TestO11y(t *testing.T) {
t.Run("find trace", func(t *testing.T) {

jc := jaeger.New("http://localhost:16686", tt.cfg.Service)
poll.WaitOn(t, func(t poll.LogT) poll.Result {
traces, err := jc.Traces(ctx, start)
if err != nil {
return poll.Error(err)
}
if len(traces) >= 1 {
return poll.Success()
}
return poll.Continue("only got %d traces", len(traces))
Comment on lines +138 to +141
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if len(traces) >= 1 {
return poll.Success()
}
return poll.Continue("only got %d traces", len(traces))
return poll.Compare(cmp.Len(traces, 1))

})
traces, err := jc.Traces(ctx, start)
assert.NilError(t, err)
assert.Assert(t, cmp.Len(traces, 1))
Expand Down