Skip to content

Conversation

Neradoc
Copy link
Contributor

@Neradoc Neradoc commented Jan 4, 2025

The restriction on the hostname for web workflow is outdated but also incompatible with custom MDNS names.
So I believe it should just accept any .local name.

  • since circuitpython#9699 the MDNS name no longer matches the filter used here.
    The format is now: cpy-board_name-big_hex_number.local
  • when assigning a custom MDNS name to a board (with the mdns module) it's the url that is used by the web workflow, which redirects to it. Using a custom name is really useful to assign meaningful names to boards.

So for example with code like this, the web workflow doesn't work unless I use the IP instead of circuitpython.local (which is redirected to bibliolights.local).

import mdns
import wifi
mdnserv = mdns.Server(wifi.radio)
mdnserv.hostname = "bibliolights"

Should fix #273 too.

@tannewt tannewt requested a review from makermelissa January 6, 2025 22:09
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. Thanks.

@makermelissa makermelissa merged commit 82dd08e into circuitpython:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hostname doesn't match expected pattern for web editor in 9.2.1 on Reverse TFT ESP32-S3 Feather

2 participants