Allow any address in .local for the web workflow #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The restriction on the hostname for web workflow is outdated but also incompatible with custom MDNS names.
So I believe it should just accept any
.local
name.The format is now: cpy-board_name-big_hex_number.local
mdns
module) it's the url that is used by the web workflow, which redirects to it. Using a custom name is really useful to assign meaningful names to boards.So for example with code like this, the web workflow doesn't work unless I use the IP instead of
circuitpython.local
(which is redirected tobibliolights.local
).Should fix #273 too.