Skip to content

Show busy while user selects port and handle canceling properly #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2025
Merged

Show busy while user selects port and handle canceling properly #292

merged 1 commit into from
Feb 8, 2025

Conversation

makermelissa
Copy link
Collaborator

Fixes #240.

FoamyGuy
FoamyGuy approved these changes Feb 8, 2025
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I tested locally with a mini sparkle motion. Thank you!

@FoamyGuy FoamyGuy merged commit dbf85b0 into circuitpython:beta Feb 8, 2025
1 check passed
@makermelissa makermelissa mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FoamyGuy FoamyGuy FoamyGuy approved these changes

@tannewt tannewt Awaiting requested review from tannewt

@dhalbert dhalbert Awaiting requested review from dhalbert

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@makermelissa @FoamyGuy