This repository was archived by the owner on Jul 15, 2021. It is now read-only.
Added promises that are resolved when the menu is closed. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use SVG badge for Travis
|
Hey @brobo, thanks for using angular-off-canvas and contributing with it. There are some considerations before merging this PR:
Could you please make those changes? Thanks once again. |
| expect(promise).toBeDefined(); | ||
| }); | ||
|
|
||
| it('should be resolved after closed', inject(function($rootScope) { |
There was a problem hiding this comment.
instead of injecting $rootScope again, you can just use rootScope
cironunes
force-pushed
the
master
branch
3 times, most recently
from
203ee0f to
6fefd97
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small feature that I needed for a project that I am working on.
Here are my results; hopefully they can be useful to someone else!