Run cyhy-domainsync service with --no-owned flag#94
Merged
Conversation
The --no-owned flag skips resolved IP addresses that are owned by a CyHy entity other than the default owner. See cisagov/cyhy-core#128 for more info.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the systemd service file to run the cyhy-domainsync command with the --no-owned flag, which filters out IP addresses owned by non-default CyHy entities during hostname housekeeping operations.
- Added
--no-ownedflag to thecyhy-domainsynccommand execution - Added inline documentation explaining the purpose of the flag
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cyhy-domainsync service with --no-owned flagcyhy-domainsync service with --no-owned flag
1 task
Co-authored-by: Jeremy Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR updates the
run-cyhy-domainsync.servicefile to runcyhy-domainsyncwith the recently-added--no-ownedflag.💭 Motivation and context
The
--no-ownedflag skips resolved IP addresses that are owned by a CyHy entity other than the default owner.See cisagov/cyhy-core#128 for more info.
🧪 Testing
Visual inspection.
✅ Pre-approval checklist
bump_versionscript if this repository is versioned and the changes in this PR warrant a version bump.✅ Pre-merge checklist
✅ Post-merge checklist