Skip to content

Run cyhy-domainsync service with --no-owned flag#94

Merged
dav3r merged 4 commits intodevelopfrom
dav3r-patch-1
Nov 17, 2025
Merged

Run cyhy-domainsync service with --no-owned flag#94
dav3r merged 4 commits intodevelopfrom
dav3r-patch-1

Conversation

@dav3r
Copy link
Member

@dav3r dav3r commented Nov 17, 2025

🗣 Description

This PR updates the run-cyhy-domainsync.service file to run cyhy-domainsync with the recently-added --no-owned flag.

💭 Motivation and context

The --no-owned flag skips resolved IP addresses that are owned by a CyHy entity other than the default owner.

See cisagov/cyhy-core#128 for more info.

🧪 Testing

Visual inspection.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

The --no-owned flag skips resolved IP addresses that are owned by a CyHy entity other than the default owner.

See cisagov/cyhy-core#128 for more info.
@dav3r dav3r requested a review from Copilot November 17, 2025 19:04
@dav3r dav3r self-assigned this Nov 17, 2025
@dav3r dav3r added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Nov 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the systemd service file to run the cyhy-domainsync command with the --no-owned flag, which filters out IP addresses owned by non-default CyHy entities during hostname housekeeping operations.

  • Added --no-owned flag to the cyhy-domainsync command execution
  • Added inline documentation explaining the purpose of the flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dav3r dav3r moved this to In Progress in CyHy System Nov 17, 2025
@jsf9k jsf9k changed the title Run cyhy-domainsync service with --no-owned flag Run cyhy-domainsync service with --no-owned flag Nov 17, 2025
@github-actions github-actions bot added the version bump This issue or pull request increments the version number label Nov 17, 2025
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my two comments.

Co-authored-by: Jeremy Frasier <jeremy.frasier@gwe.cisa.dhs.gov>
@dav3r dav3r merged commit 0be2aea into develop Nov 17, 2025
21 checks passed
@dav3r dav3r deleted the dav3r-patch-1 branch November 17, 2025 21:04
@github-project-automation github-project-automation bot moved this from In Progress to Done in CyHy System Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement This issue or pull request will add or improve functionality, maintainability, or ease of use version bump This issue or pull request increments the version number

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants