Skip to content

Mso get cache#142

Open
bobvands wants to merge 5 commits intociscoecosystem:masterfrom
bobvands:mso_get_cache
Open

Mso get cache#142
bobvands wants to merge 5 commits intociscoecosystem:masterfrom
bobvands:mso_get_cache

Conversation

@bobvands
Copy link
Copy Markdown
Contributor

@bobvands bobvands commented Jul 17, 2025

  • GET cache, stores the schema in a map using the "api/v1/schemas/" as the key
  • the cache is used ONLY when there back-to-back GETS
  • Any write method (PUT/PATCH...) invalidate the cache

Validation

  • tests added to check the parallel gets and invalidation of cache for writes

@lhercot
Copy link
Copy Markdown
Contributor

lhercot commented Jul 17, 2025 •
edited
Loading

Hi @bobvands I do not see an issue associated with this PR.

What problem are you trying to solve with this PR?
Why not implement your cache outside of the client?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akinross akinross Awaiting requested review from akinross akinross is a code owner

@anvitha-jain anvitha-jain Awaiting requested review from anvitha-jain anvitha-jain is a code owner

@gmicol gmicol Awaiting requested review from gmicol gmicol is a code owner

@lhercot lhercot Awaiting requested review from lhercot lhercot is a code owner

@sajagana sajagana Awaiting requested review from sajagana sajagana is a code owner

@samiib samiib Awaiting requested review from samiib samiib is a code owner

@shrsr shrsr Awaiting requested review from shrsr shrsr is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bobvands @lhercot