Skip to content

fix filesStore initialValue to match fileStore #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix filesStore initialValue to match fileStore #637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f87bce1
fix filesStore initialValue to match fileStore
nathancahill Sep 5, 2025
f70c49c
prettier
nathancahill Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 23 additions & 7 deletions src/lib/client/proxies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,14 +207,26 @@ export function filesFieldProxy<
export function filesProxy<
T extends Record<string, unknown>,
Path extends FormPathArrays<T, File[]>
>(form: Writable<T> | SuperForm<T>, path: Path, options?: ProxyOptions) {
>(
form: Writable<T> | SuperForm<T>,
path: Path,
options?: ProxyOptions & { empty?: 'null' | 'undefined' }
) {
const formFiles = fieldProxy(form, path as any, options) as FieldProxy<
File[] | Nullable<T, Path> | Optional<T, Path>
>;
const filesProxy = writable<FileList>(browser ? new DataTransfer().files : ({} as FileList));
let initialized = false;
let initialValue: File[] | null | undefined;

formFiles.subscribe((files) => {
if (!browser) return;

if (!initialized) {
initialValue = options?.empty ? (options.empty === 'undefined' ? undefined : null) : files;
initialized = true;
}

const dt = new DataTransfer();

if (Array.isArray(files)) {
Expand Down Expand Up @@ -244,13 +256,17 @@ export function filesProxy<
filesProxy.set(dt.files);
formFiles.set(files);
} else {
const output: File[] = [];
for (let i = 0; i < files.length; i++) {
const file = files.item(i);
if (file) output.push(file);
if (files.length > 0) {
const output: File[] = [];
for (let i = 0; i < files.length; i++) {
const file = files.item(i);
if (file) output.push(file);
}
filesProxy.set(files);
formFiles.set(output);
} else {
formFiles.set(initialValue as File[]);
}
filesProxy.set(files);
formFiles.set(output);
}
},
update(updater: Updater<File[] | Nullable<T, Path> | Optional<T, Path>>) {
Expand Down