Skip to content

Improve pronunciation playback ux #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
umlx5h wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve pronunciation playback ux #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd97e62
Playback pron at once
umlx5h Feb 8, 2019
0dbff5b
Add play pronunciation shortcut
umlx5h Feb 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ldoce5viewer/qtgui/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,25 +779,33 @@ def _autoPronPlayback(self):
self._timerAutoPron.start(_INTERVAL_AUTO_PRON)


def _onTimerAutoPronTimeout(self):
def _onTimerAutoPronTimeout(self, manual = False):
autoplayback = get_config().get('autoPronPlayback', None)
if autoplayback:
metaData = self._ui.webView.page().mainFrame().metaData()
if autoplayback == 'US' and ('us_pron' in metaData):
self._playbackAudio('/us_hwd_pron/' + metaData['us_pron'][0])
elif autoplayback == 'GB' and ('gb_pron' in metaData):
self._playbackAudio('/gb_hwd_pron/' + metaData['gb_pron'][0])
elif manual:
metaData = self._ui.webView.page().mainFrame().metaData()
if 'us_pron' in metaData:
self._playbackAudio('/us_hwd_pron/' + metaData['us_pron'][0])


def _onAutoPronChanged(self, action):
config = get_config()
if action == self._ui.actionPronUS:
config['autoPronPlayback'] = 'US'
self._onTimerAutoPronTimeout()
elif action == self._ui.actionPronGB:
config['autoPronPlayback'] = 'GB'
self._onTimerAutoPronTimeout()
else:
config['autoPronPlayback'] = ''

def playPron(self):
self._onTimerAutoPronTimeout(True)

#-----------
# Find
Expand Down Expand Up @@ -1160,6 +1168,7 @@ def act_conn(action, slot):
ui.actionGroupAutoPron.addAction(ui.actionPronUS)
ui.actionGroupAutoPron.setExclusive(True)
ui.actionGroupAutoPron.triggered.connect(self._onAutoPronChanged)
act_conn(ui.actionPlayPron, self.playPron)

self.addAction(ui.actionFocusLineEdit)
self.addAction(wp.action(QWebPage.SelectAll))
Expand Down
10 changes: 10 additions & 0 deletions ldoce5viewer/qtgui/ui/main.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -451,6 +451,8 @@
<addaction name="actionPronOff"/>
<addaction name="actionPronGB"/>
<addaction name="actionPronUS"/>
<addaction name="separator"/>
<addaction name="actionPlayPron"/>
</widget>
<widget class="QMenu" name="menuEdit">
<property name="title">
Expand Down Expand Up @@ -696,6 +698,14 @@
<string>Ctrl+Shift+N</string>
</property>
</action>
<action name="actionPlayPron">
<property name="text">
<string>Play Pronunciation</string>
</property>
<property name="shortcut">
<string>Ctrl+S</string>
</property>
</action>
<action name="actionAdvancedSearch">
<property name="icon">
<iconset>
Expand Down