Fix the pre-commit files regex pattern#411
Closed
kurtmckee wants to merge 1 commit intocitation-file-format:mainfrom
Closed
Fix the pre-commit files regex pattern#411kurtmckee wants to merge 1 commit intocitation-file-format:mainfrom
files regex pattern#411kurtmckee wants to merge 1 commit intocitation-file-format:mainfrom
Conversation
The bare `.` matches any single character, which allowed for a file named e.g. `CITATION-cff` to match in an external repo, but then cffconvert would throw an error that `CITATION.cff` could not be found. This is fixed by escaping the `.` in the `files` regex pattern so that only a file named exactly `CITATION.cff` will match.
Contributor
Author
|
Closing due to a lack of feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bare
.matches any single character, which allowed for a file named e.g.CITATION-cffto match in an external repo, but then cffconvert would throw an error thatCITATION.cffcould not be found.This is fixed by escaping the
.in thefilesregex pattern so that only a file named exactlyCITATION.cffwill match.