Skip to content

Make publisher a name variable. #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: v1.1
Choose a base branch
from
Open

Make publisher a name variable. #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
b5b349c
Moves names schema to separate file
bwiernik Aug 18, 2020
af15950
Add publisher style code to names style schema
bwiernik Aug 18, 2020
7564183
Rename form="no-name" to "none" for consistency.
bwiernik Aug 18, 2020
a5e61cf
Move publisher and publisher-place to names
bwiernik Aug 18, 2020
849d238
Make "alternate" element a name array instead of a string.
bwiernik Aug 18, 2020
cc28165
Fix wording
bwiernik Aug 18, 2020
30fd938
annotate place in csl-data
bwiernik Aug 18, 2020
7f09aa1
Add publisher data example
bwiernik Aug 18, 2020
569b3d9
Fix wording
bwiernik Aug 18, 2020
7359534
Restore label.attributes-shared
bwiernik Aug 19, 2020
9a8fd01
Add formatting attributes to cs:place
bwiernik Aug 19, 2020
c798259
Switch to unified names.component
bwiernik Nov 2, 2020
4e0f8f6
Rename `component` attribute to `name`
bwiernik Nov 3, 2020
d3692a8
All multiple cs:component elements
bwiernik Nov 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 22 additions & 9 deletions schemas/input/csl-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,18 @@
"alternate": {
"title": "Alternative name, such as screen name for online item or real name of pseudonymous author.",
"description": "E.g. rendered as 'Smith, J. [@JSmith]'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please include "examples" in the json schema, as elsewhere, @bwiernik?

"type": "string"
"type": "array",
"items": {
"$ref": "#/definitions/name-variable"
}
},
"place": {
"title": "Place associated with the name",
"description": "Can be a simple string if one location or an array of strings if multiple locations are listed (e.g. Berlin; New York)",
"type": ["string", "array"],
"items": {
"type": "string"
}
},
"parse-names": {
"type": "boolean"
Expand Down Expand Up @@ -472,6 +483,14 @@
"$ref": "#/definitions/name-variable"
}
},
"publisher": {
"title": "Publisher of the item",
"description": "e.g., [{'institution': 'Publisher', 'place': 'London, UK'}], [{'institution': 'Publisher A', 'place': 'New York, NY, US'}, {'institution': 'Publisher B', 'place': 'Berlin, Germany'}]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here; the "e.g." stuff should go in "examples"; see the title properties, or "custom".

"type": "array",
"items": {
"$ref": "#/definitions/name-variable"
}
},
"recipient": {
"type": "array",
"items": {
Expand Down Expand Up @@ -516,7 +535,7 @@
"$ref": "#/definitions/date-variable"
},
"original-date": {
"description": "[Deprecated - Use `original` related date property instead]",
"description": "[Deprecated - Use `original` related `issued` property instead]",
"$ref": "#/definitions/date-variable"
},
"submitted": {
Expand Down Expand Up @@ -634,7 +653,7 @@
"type": "string"
},
"original-publisher-place": {
"description": "[Deprecated - Use `original` related `publisher-place` property instead]",
"description": "[Deprecated - Use `original` related `publisher` property `place` property instead]",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "[Deprecated - Use `original` related `publisher` property `place` property instead]",
"description": "[Deprecated - Use `original` related `publisher` property `place` instead]",

Right?

"type": "string"
},
"original-title": {
Expand Down Expand Up @@ -662,12 +681,6 @@
"printing": {
"type": ["string", "number"]
},
"publisher": {
"type": "string"
},
"publisher-place": {
"type": "string"
},
"references": {
"type": "string"
},
Expand Down
Loading