Add norsk-henvisningsstandard-for-rettsvitenskapelige-tekster#3
Add norsk-henvisningsstandard-for-rettsvitenskapelige-tekster#3adunning merged 19 commits intocitation-style-language:mainfrom
Conversation
|
The two variants generated by the template and diffs added in this PR have now been merged into the CSL styles repo: citation-style-language/styles#8099 |
|
Thank you for contributing this! Interesting that you can get Claude to work: as of last summer, LLMs were completely incapable of writing functional CSL. I'll merge this once it's in the main styles repository, just in case you need to make any further changes. |
|
I installed the Claude extension in VScode and just asked it to review, and gave it the URL of the CSL spec and told it to use your chicago template as a source of best practices. The review it wrote was quite good. The PR for the main styles repo is here (a version with edits before those i made today has already been merged into the styles repo): citation-style-language/styles#8108 I'm not doing further work at this point in time, so feel free to merge this PR. |
|
I found one additional bug today, and fixed it (e64c99a) Since I was then working form my Windows laptop, I tried compiling the styles using make in WSL2. But when running make I got a whole bunch of line ending errors. After asking claude to suggest a way to fix this, it came up with the solution in b94d02f Here is Claude's explanation:
Please do vet the suggested fix. I don't know python, nor am I familiar with the patching code here. But the fix seemed both useful and simple to review for an expert, like @adunning, so I thought it may be useful to include it. (Ignore the .gitattributes file, I added it by mistake - it is removed by e86f2fe) |
760e847 to
47380c0
Compare
21f76b4 to
78a0dff
Compare
|
Thank you! |
Adds a template and diffs for two variants of the Norwegian legal citation style "Norsk henvisningsstandard for rettsvitenskapelige tekster".
PS: thanks for this excellent tool. I hope that it is OK to add new styles to the repo, so that others may contribute to the template and diffs too. If you prefer a different way of doing things for those of us wanting to use the style variant builder to publish style variants, please advise.