Skip to content

update national-natural-science-foundation-of-china.csl#8097

Open
johnzjq wants to merge 1 commit intocitation-style-language:masterfrom
johnzjq:patch-1
Open

update national-natural-science-foundation-of-china.csl#8097
johnzjq wants to merge 1 commit intocitation-style-language:masterfrom
johnzjq:patch-1

Conversation

@johnzjq
Copy link
Copy Markdown

@johnzjq johnzjq commented Mar 9, 2026

I fixed the citations of arxiv and web pages and tested with 100+ various citations.

CSL Styles Pull Request Template

You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.

Description

(Briefly describe the style or changes you're proposing.)

Checklist

  • Check that you've added a link to the style you used as a template in the <info> block at the beginning of the file with rel="template".
  • Check that you've added a link to the style guidelines with rel="documentation".
  • Check that you've added yourself as the <author> of the style or <contributor> for a style update.
  • Check that you've used the correct terms or labels instead of hardcoding into affixes (e.g., <text variable="page" prefix="pp. "/>).
  • Check that you've not used <text value="... if not absolutely necessary.
  • Check that you've not changed line 1 of the style.

I fixed the citations of arxiv and web pages
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes.

If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements.

To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing:

If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

😟 There are some issues with your submission.

2 tests failed

national-natural-science-foundation-of-china: must validate against the CSL 1.0.1 schema
Please check your style at http://validator.citationstyles.org/

expected `[[9, "9:0: ERROR: Element link failed to validate attributes"], [0, "ERROR: Extra element link in int...: Did not expect element macro there"], [22, "22:0: ERROR: Element style has extra content: macro"]].empty?` to be truthy, got false

national-natural-science-foundation-of-china.csl
title should include natural language version of default-locale "zh-CN" in parentheses

Please check the test report for details.

Copy link
Copy Markdown
Member

@bwiernik bwiernik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a few comments to start and be sure to run the style through the Style Validator linked above and fix the errors there. Once the validation passes, there are some additional quality updates I will note

<link href="https://isisn.nsfc.gov.cn/egrantres/template/person/%E5%8F%82%E4%B8%8E%E4%BA%BA%E6%A8%A1%E6%9D%BF-%E9%80%9A%E7%94%A8.doc" rel="documentation"/>
<author>
<name>Jiongdd</name>
<name>updated by zjq, originally made by Jiongdd</name>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add your name as a separate 'author' element after the existing author. No need to specify original/updated/etc

<!-- This style was edited with the Visual CSL Editor (http://editor.citationstyles.org/visualEditor/) -->
<info>
<title>National Natural Science Foundation of China (中文)</title>
<title>National Natural Science Foundation of China (中文) v2</title>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the v2

@POBrien333 POBrien333 changed the title update the nsfc numeric style update national-natural-science-foundation-of-china.csl Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants