update national-natural-science-foundation-of-china.csl#8097
update national-natural-science-foundation-of-china.csl#8097johnzjq wants to merge 1 commit intocitation-style-language:masterfrom
Conversation
I fixed the citations of arxiv and web pages
|
Awesome! You just created a pull request to the Citation Styles Language styles repository. One of our human volunteers will try to get in touch soon (usually within a week). In the meantime, I will run some automated checks. You should be notified of the results in a few minutes. If you haven't done so yet, please make sure your style validates and follows all our other Style Requirements. To update this pull request, visit the "Files changed" tab above, click on the ellipsis button in the top-right corner of your style, and then select "Edit file" to start editing: If you have any questions, please leave a comment and we'll get back to you. While we usually respond in English, feel free to write in whatever language you're most comfortable. |
|
😟 There are some issues with your submission. 2 tests failednational-natural-science-foundation-of-china: must validate against the CSL 1.0.1 schema national-natural-science-foundation-of-china.csl Please check the test report for details. |
bwiernik
left a comment
There was a problem hiding this comment.
Thanks a few comments to start and be sure to run the style through the Style Validator linked above and fix the errors there. Once the validation passes, there are some additional quality updates I will note
| <link href="https://isisn.nsfc.gov.cn/egrantres/template/person/%E5%8F%82%E4%B8%8E%E4%BA%BA%E6%A8%A1%E6%9D%BF-%E9%80%9A%E7%94%A8.doc" rel="documentation"/> | ||
| <author> | ||
| <name>Jiongdd</name> | ||
| <name>updated by zjq, originally made by Jiongdd</name> |
There was a problem hiding this comment.
Please add your name as a separate 'author' element after the existing author. No need to specify original/updated/etc
| <!-- This style was edited with the Visual CSL Editor (http://editor.citationstyles.org/visualEditor/) --> | ||
| <info> | ||
| <title>National Natural Science Foundation of China (中文)</title> | ||
| <title>National Natural Science Foundation of China (中文) v2</title> |

I fixed the citations of arxiv and web pages and tested with 100+ various citations.
CSL Styles Pull Request Template
You're about to create a pull request to the CSL styles repository.
If you haven't done so already, see https://github.com/citation-style-language/styles/blob/master/CONTRIBUTING.md for instructions on how to contribute, and https://github.com/citation-style-language/styles/blob/master/STYLE_REQUIREMENTS.md for the requirements a style must meet before acceptance.
In addition, please fill out the pull request template below.
Description
(Briefly describe the style or changes you're proposing.)
Checklist
<info>block at the beginning of the file withrel="template".rel="documentation".<author>of the style or<contributor>for a style update.<text variable="page" prefix="pp. "/>).<text value="...if not absolutely necessary.