fix(clrcore-v2): Fix PR #2546 and Add Delegate Serialization Support by manups4e · Pull Request #3409 · citizenfx/fivem

manups4e · 2025-05-19T18:40:20Z

Goal of this PR

Re-enable (De)Serialization using the new custom msgpack provided in #2546

How is this PR achieving the goal

This PR adds back all Thorium's modifications and some extras to be fully compatible with the new MsgPack (de)serialization.

Warning

Improve MsgPack Serialization: Delegate Support, List Fixes, and Byte Array Handling msgpack-cs#2 needs to be merged before applying this PR for it to be working on production.

This PR applies to the following area(s)

Successfully tested on

FXServer and FiveM client

Game builds: N/A

Platforms: Windows

Checklist

Code compiles and has been tested successfully.
Code explains itself well and/or is documented.
My commit message explains what the changes do and what they are for.
No extra compilation warnings are added by these changes.

Fixes issues

fixes #2653, #2613, #2590, #2582, #2571,

manups4e · 2025-05-19T18:41:54Z

i see the commits have wrong naming convention 🤔 question is how do i change the names XD

Gogsi · 2025-05-19T18:49:22Z

If you use the Git in Visual Studio (I assume other clients are similar), right click on the commit before your oldest commit, Reset -> Keep changes.

This will remove all of your commits, but will keep all of your changes in the uncommitted changes on the right. So you can can make 1 new commit with all of the changes in it and the right naming.

Once you do that to overwrite your changes to github, you will need to force push. Git -> Open In Command Prompt, and type in git push --force

EDIT: Apparently you can also select all of your commits and right click -> Squash commits, instead of resetting and making a new one. Still needs a force push

code/client/clrcore-v2/Interop/ReferenceFunctionManager.cs

Co-authored-by: thorium <102315529+thorium-cfx@users.noreply.github.com>

…nager

…o allow separate module building

…d encryption methods

…convert internally

Previously, MsgPackReferenceRegistrar.CreateFunc was only set in a specific case. It is now properly initialized during startup to avoid missing reference handling.

- Async exports will require a full rewrite as in the current state this commit is more like a patch

This update adds strongly-typed support for local and remote exports, avoiding the use of dynamic objects. The new system uses Coroutine<T> and Promise<T> for async handling, while keeping compatibility with old Exports[] system Before: var result = await Exports["my_script", "GetUser"](); // dynamic After: var user = await Exports.Get<User>("my_script", "GetUser")(); This change improves safety and intellisense support.

Allows calling typed exports like: var result = await Exports.Get<int>("myres", "sum", 1, 2); Same logic for Exports.Local.Get<T>

…s runtimes

IstuntmanI · 2025-10-10T22:52:48Z

Any news about this? Are more changes still needed?
Maybe this finishes the Mono v2 implementation, and it could be finally out of beta. Also publishing on nuget.org would be great.

Great work here!

manups4e · 2025-10-11T06:22:52Z

the whole monov2 can still be enhanced but in this current state of the PR along side with the pending PR in msgpack-cs

is considered stable as it fixes all the bugs present in msgpack when it came out.
I don't think it'll ever be merged because CFX dropped support completely to the mono runtime to work on a new future .net runtime.

manups4e · 2026-03-20T16:34:24Z

Closing pull request due to support dropping for the Mono runtime.
Thanks for the fun ride ❤️

github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label May 19, 2025

manups4e changed the title ~~Fix PR #2546 and Add Delegate Serialization Support~~ [MonoV2] Fix PR #2546 and Add Delegate Serialization Support May 19, 2025

manups4e force-pushed the master branch from 648cc8a to b0136eb Compare May 19, 2025 19:29

FabianTerhorst reviewed May 20, 2025

View reviewed changes

code/client/clrcore-v2/Interop/ReferenceFunctionManager.cs Outdated Show resolved Hide resolved

FabianTerhorst mentioned this pull request May 20, 2025

Improve MsgPack Serialization: Delegate Support, List Fixes, and Byte Array Handling citizenfx/msgpack-cs#2

Merged

manups4e commented May 21, 2025

View reviewed changes

code/client/clrcore-v2/Interop/ReferenceFunctionManager.cs Outdated Show resolved Hide resolved

manups4e changed the title ~~[MonoV2] Fix PR #2546 and Add Delegate Serialization Support~~ fix(clrcore-v2): Fix PR #2546 and Add Delegate Serialization Support May 22, 2025

manups4e and others added 2 commits May 22, 2025 16:38

fix(clrcore-v2): Fix PR citizenfx#2546 and Add Delegate Serialization

ebf4473

Co-authored-by: thorium <102315529+thorium-cfx@users.noreply.github.com>

feat(clrcore-v2): Added debug exception for MsgPackFunc in FunctionMa…

224d0cd

…nager

manups4e force-pushed the master branch from c840843 to f4300ba Compare May 22, 2025 14:50

feat(clrcore-v2): Added reference to new msgpack Callback Injection t…

eaecb14

…o allow separate module building

manups4e force-pushed the master branch from f4300ba to eaecb14 Compare May 22, 2025 14:53

manups4e added 2 commits May 22, 2025 18:07

fix(clrcore-v2): restore exception

7d19cac

tweak(vendor/msgpack-cs): add corrected submodule listing for msgpack-cs

34ef8f8

github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels May 22, 2025

manups4e added 4 commits May 24, 2025 17:48

fix(clrcore-v2): restore buffer before throwing exception

0169b75

fix(clrcore-v2): fix CString memoryleak in null check

a80003d

feat(vendor/msgpack-cs): updated submodule to last commit

c35517a

fix(clrcore-v2): correctly get method info from delegate in exception

e5c63f2

github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels May 26, 2025

manups4e added 6 commits May 28, 2025 16:45

feat(vendor/msgpack-cs): update submodule to latest PR (fix build)

2748f7f

feat(clrcore-v2): Added MsgPackUtils for extended msgpack features an…

176bbde

…d encryption methods

fix(clrcore-v2): fix scheduler for clientside scheduled execution

1262bdf

Merge branch 'citizenfx:master' into master

aaf07e5

Merge branch 'master' of https://github.com/manups4e/fivem

2bfb29b

feat(vendor/msgpack-cs): updated module to latest commit

428a859

manups4e added 11 commits June 11, 2025 10:49

feat(clrcore-v2): summaries for public BaseScript methods

b233924

feat(clrcore-v2): Events registering via method accepts Delegate and …

56acce0

…convert internally

feat(clrcore-v2): added callbacks system description

1b87798

fix(clrcore-v2): use the real error message for registering multiple CBs

3e367d8

feat(vendor/msgpack-cs): update submodule to latest commit

1cd3203

fix(vendor/msgpack-cs): checkout to correct commit hash

c26fe04

fix(clrcore-v2): Ensure CreateFunc is initialized on startup

750c1d8

Previously, MsgPackReferenceRegistrar.CreateFunc was only set in a specific case. It is now properly initialized during startup to avoid missing reference handling.

fix(clrcore-v2): Fix for async exports C# <-> Lua and C# <-> C#

20ff4c7

- Async exports will require a full rewrite as in the current state this commit is more like a patch

feat(clrcore-v2): add Get<T> overload with args for immediate invocation

0de46dc

Allows calling typed exports like: var result = await Exports.Get<int>("myres", "sum", 1, 2); Same logic for Exports.Local.Get<T>

fix(exports): use table.pack to normalize async result handling acros…

0af1de5

…s runtimes

BuddiesTV mentioned this pull request Jun 29, 2025

tweak(exports): wrap non-table returns in table #3483

Closed

4 tasks

manups4e added 4 commits July 1, 2025 12:34

fix(clrcore-v2): use cfx_internal events and code cleanup

578cd3c

feat(scripting-lua): cross ScRTs callbacks logic for Lua

324fe90

tweak(mono-v2): extend Mono v2 experimental period

0cc8b35

Fix(clrcore-v2): Do not return if no callback available

979a46c

github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Jul 1, 2025

manups4e added 3 commits July 1, 2025 17:49

feat(clrcore-v2): finalize callbacks cross ScRTs

6b05350

feat(clrcore-v2): use lua provided functions

c366528

fix(clrcore-v2): fix error handling for 1 return type

fc0b417

github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Jul 2, 2025

manups4e added 3 commits July 2, 2025 11:52

fix(clrcore-v2): revert lua scheduler export changes

b0d8a22

fix(clrcore-v2): fix async export cross ScRTs

53f9385

feat(clrcore-v2): fix lua client callback params order

4c461cd

manups4e closed this Mar 20, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(clrcore-v2): Fix PR #2546 and Add Delegate Serialization Support#3409

fix(clrcore-v2): Fix PR #2546 and Add Delegate Serialization Support#3409
manups4e wants to merge 39 commits intocitizenfx:masterfrom
manups4e:master

manups4e commented May 19, 2025 •

edited

Loading

Uh oh!

manups4e commented May 19, 2025

Uh oh!

Gogsi commented May 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

IstuntmanI commented Oct 10, 2025 •

edited

Loading

Uh oh!

manups4e commented Oct 11, 2025

Uh oh!

manups4e commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

manups4e commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal of this PR

How is this PR achieving the goal

Warning

This PR applies to the following area(s)

Successfully tested on

Checklist

Fixes issues

Uh oh!

manups4e commented May 19, 2025

Uh oh!

Gogsi commented May 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IstuntmanI commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manups4e commented Oct 11, 2025

Uh oh!

manups4e commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

manups4e commented May 19, 2025 •

edited

Loading

Gogsi commented May 19, 2025 •

edited

Loading

IstuntmanI commented Oct 10, 2025 •

edited

Loading