fix(msgpack-cs): fix UTF-8 encoding of UTF-16 surrogate pairs#7
Merged
prikolium-cfx merged 1 commit intocitizenfx:masterfrom Jul 30, 2025
Merged
fix(msgpack-cs): fix UTF-8 encoding of UTF-16 surrogate pairs#7prikolium-cfx merged 1 commit intocitizenfx:masterfrom
prikolium-cfx merged 1 commit intocitizenfx:masterfrom
Conversation
Contributor
|
Looks pretty good to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
Fix incorrect UTF-8 encoding logic by properly handling surrogate pairs in UTF-16 input.
How is this PR achieving the goal
This PR updates the UTF-8 encoding functions to correctly detect and encode surrogate pairs as 4-byte UTF-8 sequences. It also adds fallback encoding for invalid or unmatched surrogates using the replacement character (U+FFFD).