Open
Conversation
JelteF
reviewed
Jul 6, 2022
Comment on lines
-14
to
-17
| if [ "$1" = "master" ]; then | ||
| ./download-hammerdb.sh 4.4 | ||
| git clone https://github.com/TPC-Council/HammerDB --branch master HammerDB-master | ||
| cp -R HammerDB-4.4/{lib,include,bin} HammerDB-master |
Contributor
There was a problem hiding this comment.
Why remove the option to download from git?
JelteF
reviewed
Jan 27, 2023
| cd "$(dirname "$0")" | ||
|
|
||
| RESOURCE_GROUP=$1 | ||
| az group delete -y --name "$RESOURCE_GROUP" --no-wait > /dev/null |
JelteF
approved these changes
Jan 27, 2023
Contributor
JelteF
left a comment
JelteF
left a comment
There was a problem hiding this comment.
Looks good overal, except for the two comments I left. If you address those we can merge this (better late than never)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.