Created Data Hackathon page and made minor changes to the project pages #171
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'Events' page and collection, and updates several project pages to a new, more detailed format. The changes are a great improvement in terms of content. However, there are several copy-paste errors across the new project pages that need to be fixed. Additionally, there are some maintainability and security issues that should be addressed. A debug line was also found on the new events page.
| <div style="flex: 1; min-width: 250px; max-width: 400px; text-align: center;"> | ||
| <a href="https://civictechdc.org" target="_blank"> | ||
| <img src="assets/images/logos/civic-tech-dc.svg" style="max-height: 80px; width: auto;" alt="Civic Tech DC Logo"> | ||
| <img src="assets/images/events/data_showcase/civictech.png" style="max-height: 80px; width: auto;" alt="Civic Tech DC Logo"> |
There was a problem hiding this comment.
The src attribute for this image uses a relative path (assets/...). This can lead to broken images if the page is accessed from a URL with a different depth. To ensure the image always loads correctly, please use a root-relative path by adding a leading slash (/).
| <img src="assets/images/events/data_showcase/civictech.png" style="max-height: 80px; width: auto;" alt="Civic Tech DC Logo"> | |
| <img src="/assets/images/events/data_showcase/civictech.png" style="max-height: 80px; width: auto;" alt="Civic Tech DC Logo"> |
| <a href="https://github.com/civictechdc/congressional-tech" class="usa-button" style="background-color: #253551; color: #ffffff;" target="_blank" rel="noopener noreferrer"> | ||
| 🧩 GitHub Repo | ||
| </a> | ||
| <a href="https://electrifydmv.org" class="usa-button" style="background-color: #253551; color: #ffffff;" target="_blank" rel="noopener noreferrer"> |
There was a problem hiding this comment.
The project website link points to https://electrifydmv.org, which seems to be for a different project. This looks like a copy-paste error. Please update it to the correct URL for the "Congressional Modernization" project, or remove the button if there is no project website.
| <a href="https://www.electrifydc.org/" class="usa-link usa-link--external" target="_blank" rel="noopener noreferrer">Electrify DC | ||
| </a>, Building Innovation Hub, Go Electric DMV, and several DMV-area jurisdictions and professional associations. | ||
| </p> |
There was a problem hiding this comment.
There is a stray closing </p> tag here, and the <a> tag is split across two lines. This results in invalid HTML. Please correct the markup.
| <a href="https://www.electrifydc.org/" class="usa-link usa-link--external" target="_blank" rel="noopener noreferrer">Electrify DC | |
| </a>, Building Innovation Hub, Go Electric DMV, and several DMV-area jurisdictions and professional associations. | |
| </p> | |
| <a href="https://www.electrifydc.org/" class="usa-link usa-link--external" target="_blank" rel="noopener noreferrer">Electrify DC</a>, Building Innovation Hub, Go Electric DMV, and several DMV-area jurisdictions and professional associations. |
| <li>Connects homeowners with <strong>qualified and trusted contractors</strong></li> | ||
| <li>Shares <strong>localized info</strong> on rebates and incentives</li> | ||
| <li>Unlocks <strong>IRA workforce funding</strong> and training opportunities</li> | ||
| </ul> |
There was a problem hiding this comment.
The content inside this usa-alert box seems to be copy-pasted from the "Electrify DMV" project page. It mentions connecting homeowners with contractors, which is not relevant to the "Election Administration and Voting Survey" project. Please replace this with content relevant to the EAVS project.
| <section class="padding-y-1 usa-prose maxw-none"> | ||
| <div class="grid-container"> | ||
| <h2 class="font-sans-lg">🚀 Our Impact</h2> | ||
| <p>Join us to help detect and deter vote suppression and fraud! By helping the Campaign Legal Center to identify outliers in voter registration and votes, we enable their attorneys to take action against any wrongdoing that may be causing the anomalies.</p> |
There was a problem hiding this comment.
The content of the "Our Impact" section appears to be copy-pasted from the EAVS project page, as it discusses vote suppression and the Campaign Legal Center. This is not relevant to the StreetView project. Please update this with the correct impact statement for this project.
| {% assign upcoming_events = site.events | sort: "date" %} | ||
| {% assign upcoming_events = upcoming_events | where_exp: "e", "e.date >= site.time" %} | ||
| {% for event in upcoming_events %} | ||
| <p>Event Debug: {{ event.title }} → {{ event.url }}</p> |
There was a problem hiding this comment.
This line appears to be a debug statement. It should be removed before this page goes live.
2 participants
No description provided.