Add support for Ruby 3.4#38
Conversation
|
@mattyb can someone at Civis approve the workflow run on this PR? |
mikesaelim
left a comment
mikesaelim
left a comment
There was a problem hiding this comment.
Unfortunately, my PR #37 got merged in ahead of yours, and it's created some merge conflicts with your PR. Could you rebase your PR on top of main? Sorry about this.
Gemfile
Outdated
| gem 'rake', '~> 13.0' | ||
| gem 'rspec', '~> 3.9' | ||
| gem 'rubocop', '~> 1.69.2' | ||
| gem 'timecop', '~> 0.9.1' |
There was a problem hiding this comment.
I was going to ask if these could be put back in the gemspec file, but I guess this is because of a new Rubocop cop? https://docs.rubocop.org/rubocop/cops_gemspec.html#gemspecdevelopmentdependencies
There was a problem hiding this comment.
yeah and same with the MFA requirement added to the gemspec and grep_v stuff.
There was a problem hiding this comment.
LggTM. thank you so much for taking this on <3
@scudco i will cut a release very soon.
3 participants
No description provided.