Conversation
Update Go version from 1.24.9 to 1.24.12 in go.mod and all GitHub Actions workflow files to address standard library vulnerabilities detected by govulncheck. Vulnerabilities fixed: - GO-2026-4341: Memory exhaustion in query parameter parsing in net/url - GO-2026-4340: Handshake messages processed at incorrect encryption level in crypto/tls - GO-2025-4175: Improper application of excluded DNS name constraints when verifying wildcard names in crypto/x509 - GO-2025-4155: Excessive resource consumption when printing error string for host certificate validation in crypto/x509
alessandroargentieri
left a comment
alessandroargentieri
left a comment
There was a problem hiding this comment.
Do we have the API /v2/vpc/* released already?
|
if it's the exact copy of the methods from /networks /firewalls, /ips, /loadbalancers is fine, still it cannot be merged and released before the API is released (MR is in review phase at the moment) |
The subnets and routes endpoints under /v2/vpc/networks/{id}/subnets
are not ready for the VPC API. This removes all related client methods,
tests, and documentation while keeping the underlying types in network.go
intact.
Bumps Go from 1.24.12 to 1.24.13 to fix GO-2026-4337 (unexpected session resumption in crypto/tls). Updates go.mod and all workflow fallback versions.
The DNS endpoints under /v2/vpc/dns are not ready for the VPC API. This removes all related client methods, tests, and documentation for both DNS domains and DNS records.
|
There is a lot of code duplication here, do we want to refactor to a shared implementation so that we don't need to perform updates in two places in the future? For example:- firewall.go has IsUsingDefaultRules(firewallID) which is not mirrored in the VPC methods The original network.go includes ListSubnets, GetSubnet, CreateSubnet, DeleteSubnet, AttachSubnetToInstance, DetachSubnetFromInstance. We said to skip, but lets include for completeness since they are already defined in civogo. |
This reverts commit 2eb2952.
4 participants
No description provided.