This repository was archived by the owner on Feb 19, 2021. It is now read-only.
Add instance name to element and other small improvements#106
Open
leandromatos wants to merge 8 commits intocjgammon:masterfrom
leandromatos:master
Open
Add instance name to element and other small improvements#106leandromatos wants to merge 8 commits intocjgammon:masterfrom leandromatos:master
leandromatos wants to merge 8 commits intocjgammon:masterfrom
leandromatos:master
Conversation
added 8 commits
May 11, 2017 18:23
By adding the instance name to the element, you can manipulate it via css or js. Some code minifiers remove the ids from the svg elements, so, in this case the instance name is added to the element's class and not to the ID
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By adding the instance name to the element, you can manipulate it via css or js. Some code minifiers remove the ids from the svg elements, so, in this case the instance name is added to the element's class and not to the ID.
The other improvements are simple, I changed the software name in README.md, as well I removed unnecessary messages that appeared on the console.