-
-
Notifications
You must be signed in to change notification settings - Fork 885
feat: add optional hotkey for post-processing request #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@jacksongoode I note you added a confused reaction, is there something I should clarify? |
|
Ah, I was just a little concerned around the complexity and use of a kind of hotkey? Is it like a modifier? Or a separate hotkey that is pressed after the generic hotkey is pressed. And also how does this interact with the push to talk setting? |
|
Thanks @jacksongoode As well as the existing standard hotkey, users can configure a second (optional) hotkey (e.g., Ctrl+Shift+Space) which applies post-processing regardless of global setting The post-processing hotkey behaves identically to the standard transcribe hotkey with respect to push-to-talk It's implemented as it's own hotkey as I figured this was simple and explicit and does not alter any existing behaviour while allowing users to configure a similar, or completely different combination. I'll fix up those merge conflicts from the drift shortly and add a screenshot. |
df74223 to
16c789d
Compare
|
Rebased and updated PR with screenshots |
c07237f to
dc6477a
Compare
|
wow i hate new hotkeys normally, but since this is already under the debug flag i am kind of okay with it. i may merge this |
|
realizing not sure what the ux expection is (currently it is everything is post processed, this would mean you would only post process with this shortcut) im not really sure what the right behavior is. this might need to wait for a broader change to define shortcuts, where we can easily control the flow of what happens when pressing a shortcut |
|
Hey @sammcj can you rebase this code and remove package-lock from the PR |
be16891 to
6aca846
Compare
6aca846 to
14e1719
Compare
|
@cjpais done :) |
This PR adds support for optionally setting a dedicated hotkey which triggers post-processing after a request.
This is useful if you don't usually want post processing, but still want to make use of it for specific request.
Note: I have no Rust experience, so if the code quality or implementation is not up to standard or does not align with your direction I totally understand if you wish to reject the PR.