Skip to content

Conversation

@sammcj
Copy link

@sammcj sammcj commented Nov 18, 2025

This PR adds support for optionally setting a dedicated hotkey which triggers post-processing after a request.

This is useful if you don't usually want post processing, but still want to make use of it for specific request.

  • Linting / formatter run before raising PR
  • Builds locally and runs without issue

Note: I have no Rust experience, so if the code quality or implementation is not up to standard or does not align with your direction I totally understand if you wish to reject the PR.

image image

@sammcj
Copy link
Author

sammcj commented Nov 23, 2025

@jacksongoode I note you added a confused reaction, is there something I should clarify?

@jacksongoode
Copy link
Contributor

Ah, I was just a little concerned around the complexity and use of a kind of hotkey? Is it like a modifier? Or a separate hotkey that is pressed after the generic hotkey is pressed. And also how does this interact with the push to talk setting?

@sammcj
Copy link
Author

sammcj commented Dec 1, 2025

Thanks @jacksongoode

As well as the existing standard hotkey, users can configure a second (optional) hotkey (e.g., Ctrl+Shift+Space) which applies post-processing regardless of global setting

The post-processing hotkey behaves identically to the standard transcribe hotkey with respect to push-to-talk

It's implemented as it's own hotkey as I figured this was simple and explicit and does not alter any existing behaviour while allowing users to configure a similar, or completely different combination.

I'll fix up those merge conflicts from the drift shortly and add a screenshot.

@sammcj sammcj force-pushed the post_process_hotkey branch from df74223 to 16c789d Compare December 1, 2025 02:48
@sammcj sammcj marked this pull request as draft December 1, 2025 02:57
@sammcj sammcj marked this pull request as ready for review December 1, 2025 03:02
@sammcj
Copy link
Author

sammcj commented Dec 1, 2025

Rebased and updated PR with screenshots

@sammcj sammcj force-pushed the post_process_hotkey branch from c07237f to dc6477a Compare December 1, 2025 03:04
@cjpais
Copy link
Owner

cjpais commented Dec 4, 2025

wow i hate new hotkeys normally, but since this is already under the debug flag i am kind of okay with it. i may merge this

@cjpais
Copy link
Owner

cjpais commented Dec 17, 2025

realizing not sure what the ux expection is (currently it is everything is post processed, this would mean you would only post process with this shortcut) im not really sure what the right behavior is. this might need to wait for a broader change to define shortcuts, where we can easily control the flow of what happens when pressing a shortcut

@cjpais
Copy link
Owner

cjpais commented Jan 10, 2026

Hey @sammcj can you rebase this code and remove package-lock from the PR

@sammcj sammcj force-pushed the post_process_hotkey branch 2 times, most recently from be16891 to 6aca846 Compare January 10, 2026 05:11
@sammcj sammcj force-pushed the post_process_hotkey branch from 6aca846 to 14e1719 Compare January 10, 2026 05:13
@sammcj
Copy link
Author

sammcj commented Jan 10, 2026

@cjpais done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants