Fix KML preview failure caused by ol.featureloader#112
Merged
EricSoroos merged 1 commit intockan:masterfrom Nov 4, 2025
Merged
Fix KML preview failure caused by ol.featureloader#112EricSoroos merged 1 commit intockan:masterfrom
EricSoroos merged 1 commit intockan:masterfrom
Conversation
|
LGTM. Thanks for the fix. |
Author
|
@EricSoroos Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Uncaught TypeError: kmlLoader is undefinedwhen loading KML files.This patch addresses the issue #107 after the OpenLayers migration done in #102.
It replaces the use of global
ol.featureloaderAPI used inOL_HELPERS.createKMLLayerfunction, causing KML previews to fail with the browser error:Uncaught TypeError: can't access property "call", kmlLoader is undefined.The
ol.featureloader.loadFeaturesXhr(...)custom loader is replaced with OpenLayers 9–compatible approach usingol.source.Vectorconfigured withurl,format, andol.loadingstrategy.allrestoring the KML preview functionality.Tested on CKAN 2.11 ckanext-geoview ("ol": "9.2.4") with multiple .kml resources now render successfully in map previews.