Conversation
bellisk
force-pushed
the
update-facet-list
branch
from
9f7b955 to
7139fc2
Compare
bellisk
force-pushed
the
update-facet-list
branch
from
7139fc2 to
4370856
Compare
Member
|
I checked out this branch and tested it locally and I found no errors, so LGTM 😊 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was initially just to pass in the
search_facetsparameter into thefacet_list.htmltemplate, as it's now required. Then I got the idea of cleaning up the oldcobject from the templates too.@pdelboca Do I have it right that we should be passing these extra variables along as
extra_varsand not adding them to thegobject, in the views? I didn't change that yet, but I can also clean up the places where we add to thegobject there as well.