Editor name - if init target has ID, use ID as editor name.#257
Open
SpencerGresoro wants to merge 5 commits intockeditor:masterfrom
Open
Editor name - if init target has ID, use ID as editor name.#257SpencerGresoro wants to merge 5 commits intockeditor:masterfrom
SpencerGresoro wants to merge 5 commits intockeditor:masterfrom
Conversation
…nstance rather than just editorN ...
testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is very important to our implementation that this behavior exists. This is how it function in vanilla ck4 and I see no harm in adding in the optional ability to support it. IF your target has an ID, use that as the editor.name rather than just assigning numeric values, such as editor1, editor2.
Please consider adding this to MASTER, it would greatly be appreciated.