Skip to content

Added line height css variable#18725

Closed
przemyslaw-zan wants to merge 2 commits intock/11360from
ck/18634
Closed

Added line height css variable#18725
przemyslaw-zan wants to merge 2 commits intock/11360from
ck/18634

Conversation

@przemyslaw-zan
Copy link
Copy Markdown
Member

@przemyslaw-zan przemyslaw-zan commented Jun 17, 2025

Suggested merge commit message (convention)

Other (core): Added the --ck-content-line-height css variable. Closes #18634.

MAJOR BREAKING CHANGE: The editor now enforces a default line height of 1.5, affecting both editing and rendered content. This may impact existing styling and layout, so custom line-height settings should be reviewed.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

@pomek
Copy link
Copy Markdown
Member

pomek commented Jun 17, 2025

I would add a breaking change note to the changelog.

MAJOR BREAKING CHANGE: The editor now enforces a default line height of 1.5, affecting both editing and rendered content. This may impact existing styling and layout, so custom line-height settings should be reviewed.

Copy link
Copy Markdown
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pomek
Copy link
Copy Markdown
Member

pomek commented Jun 20, 2025

Closing in favor of #18736.

@pomek pomek closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants