Insert text should prevent browser from breaking DOM structure.#18729
Merged
Insert text should prevent browser from breaking DOM structure.#18729
Conversation
Witoso
previously approved these changes
Jun 17, 2025
mmotyczynska
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Internal (typing): The engine should prevent the browser from modifying the DOM structure while user is typing. See #18722.
Additional information
The
beforeinputevent target ranges used to be fixed by the selection post-fixer in a generic way (inside EditingController). Now the target ranges are fixed on demand after translating from the view to the model ranges.