Conversation
Witoso
commented
Jun 23, 2025
docs/updating/update-to-46.md
Outdated
Comment on lines
+41
to
+42
| | `--ck-color-selector-caption-background` | `--ck-content-color-selector-caption-background` | | ||
| | `--ck-color-selector-caption-text` | `--ck-content-color-selector-caption-text` | |
Member
Author
There was a problem hiding this comment.
@pszczesniak WDYT about renaming these? add some table word
godai78
reviewed
Jun 24, 2025
godai78
previously approved these changes
Jun 24, 2025
Contributor
godai78
left a comment
godai78
left a comment
There was a problem hiding this comment.
LGTM except for the placement.
godai78
previously approved these changes
Jun 24, 2025
godai78
previously approved these changes
Jun 24, 2025
pszczesniak
approved these changes
Jun 24, 2025
godai78
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other (highlight, image, list, table, theme): Align content area CSS variables to --ck-content-* prefix. Closes #18735.
Other (table): Fix the table's CSS variables, which had
-selector-string in their name.MAJOR BREAKING CHANGE: Content area CSS variables have been renamed to use the
--ck-content-*prefix for better consistency in Highlight, Image, List, Table features. This requires action if you have overridden the variables. See the update guide for details.MAJOR BREAKING CHANGE: Table-related CSS variables with improper
*-selector-*naming have been renamed to use*-table-*for better clarity. This requires action if you have overridden the variables. See the update guide for details.Additional information
See #18710.