Open
Conversation
ConnKey factories are intermediaries that encapsulate the details of how to instantiate ConnKeys, which codify the hash input for connection lookups.
The InitTuple() implementation here is a placeholder for a fuller one following later, when we do away with the need for ConnTuple.
This touches quite a few places, but each just swaps out existing APIs and/or zeek::detail::ConnKey instances.
The new key-based Connection constructor replaces the former, and the new ConnKey class tree replaces the latter.
ckreibich
force-pushed
the
topic/christian/extensible-conntuples
branch
from
0d1584a to
7ee9b24
Compare
Given IP-aware ConnKeys, ConnTuples aren't really required any more. ConnTuple had two benefits: - It preserved the original src/dst orientation from the packet headers it was based on, which IPBasedConnKey now tracks and provides accessor methods for. - In IPBasedAnalyzer::AnalyzePacket() its instance survived past the std:move() of the key into NewConn(), which we sidestep by keeping the original src address and port around until we need after the connection is obtained.
ckreibich
force-pushed
the
topic/christian/extensible-conntuples
branch
from
7ee9b24 to
965729a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.