Mark deprecated name arg and align client creation in tests

Agent-Logs-Url: https://github.com/cl-sdk/io.github.cl-sdk.wst/sessions/9199f57b-a9c4-424c-9c46-02842ca3d950

Co-authored-by: diasbruno <362368+diasbruno@users.noreply.github.com>

Author: Copilot

feature-flag/routing.lisp

@@ -44,7 +44,7 @@ Example:
                                         (request-data-key :feature-flag-evaluation-context))
   "Create a feature-flag client composed with request-scoped context.
 OBJECT-OF-INTEREST defaults to REQUEST and is used by RESOLVE-PROVIDER.
-NAME is accepted for backward compatibility; it was used by the removed CREATE-CLIENT API and is currently unused.
+NAME is deprecated and accepted only for backward compatibility; it was used by the removed CREATE-CLIENT API and is currently unused.
 Example:
   (client-for-request request :domain \"payments\" :evaluation-context '(:app \"checkout\"))
   => #<CLIENT ...>"

t/feature-flag-tests.lisp

@@ -122,9 +122,9 @@
 (test evaluation-context-merges-client-and-invocation-with-right-precedence
   (let* ((provider (make-instance 'static-provider :name "static"
                                   :values '(("flag-a" . t))))
-         (client (make-instance 'client :provider provider
-                                :domain "default"
-                                :client-evaluation-context '(:shared :client :client-only 2))))
+         (client (acquire-client provider)))
+    (setf (slot-value client 'io.github.cl-sdk.wst.feature-flag::evaluation-context)
+          '(:shared :client :client-only 2))
     (is-true (get-boolean-value client "flag-a" nil :evaluation-context '(:shared :call :call-only 3)))
     (let ((ctx (static-provider-last-context provider)))
       (is (eq :call (getf ctx :shared)))