Skip to content

Add SQLite backed session - #20

Merged
diasbruno merged 19 commits into
developmentfrom
copilot/create-sqlite-backed-session-store
May 19, 2026
Merged

Add SQLite backed session#20
diasbruno merged 19 commits into
developmentfrom
copilot/create-sqlite-backed-session-store

Conversation

Copilot AI commented Apr 21, 2026

Copy link
Copy Markdown
Contributor
  • Review new comment requesting lifecycle transition recheck
  • Check recent workflow runs/logs for CI context
  • Verify current transition coverage in SQLite session tests
  • Apply minimal test adjustments only if coverage gaps are found
  • Run targeted validation
  • Run final Code Review + CodeQL validation
  • Reply to the new PR comment with commit hash

Comment thread session/sqlite-store.lisp Outdated
Copilot AI requested a review from diasbruno April 21, 2026 11:53
@diasbruno
diasbruno marked this pull request as ready for review April 21, 2026 16:02
@diasbruno
diasbruno force-pushed the copilot/create-sqlite-backed-session-store branch from 9fee9af to 23f2ee3 Compare April 25, 2026 01:32
@diasbruno
diasbruno force-pushed the copilot/create-sqlite-backed-session-store branch from 23f2ee3 to c7056c2 Compare May 18, 2026 13:43
@diasbruno diasbruno changed the title Add wst.session SQLite backend with protocol-complete persistence and expiry handling Add SQLite backed session May 18, 2026
@diasbruno
diasbruno force-pushed the copilot/create-sqlite-backed-session-store branch 2 times, most recently from 4e4ca0a to cb9effc Compare May 19, 2026 00:45
@diasbruno

Copy link
Copy Markdown
Member

@copilot Check if there are more tests to add.

Copilot AI commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Check if there are more tests to add.

Added more coverage in ae3ca0e (plus follow-ups 1d93957 and c5f9286): new tests now validate initialize-sqlite-store idempotency and type-check enforcement, and include explicit session-id roundtrip assertions in the idempotency scenario. No UI changes in this PR, so no screenshot applies.

Copilot AI changed the title Add SQLite backed session Add SQLite backed session May 19, 2026
@diasbruno

Copy link
Copy Markdown
Member

@copilot Check if there are more tests to add, and update the tests that uses the access-session as it now update the last-accessed-at field.

Copilot AI commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Check if there are more tests to add, and update the tests that uses the access-session as it now update the last-accessed-at field.

Implemented in 3b0cf43: I added/updated tests around access-session to cover the new last-accessed-at behavior, including a dedicated test that forces stale access timestamps and verifies access-session updates both updated-at and last-accessed-at while preserving session data. No UI changes in this PR, so no screenshot applies.

@diasbruno

Copy link
Copy Markdown
Member

@copilot Here are some states to check:

create -> active
active -> renewed
active -> expired
active -> terminated
renewed -> active

@diasbruno
diasbruno force-pushed the copilot/create-sqlite-backed-session-store branch from 233cfa6 to adcd773 Compare May 19, 2026 02:52

Copilot AI commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Here are some states to check:

...

Implemented in a509c79: I added lifecycle transition coverage in sqlite-store-session-state-transitions, validating create -> active, active -> renewed, active -> expired, active -> terminated, and renewed -> active with explicit assertions using create-session, access-session, renew-session, terminate-session, and session-exists-p. No UI changes in this PR, so no screenshot applies.

@diasbruno

Copy link
Copy Markdown
Member

@copilot Here are some states transitions to recheck:

create -> active
active -> renewed
active -> expired
active -> terminated
renewed -> active

Copilot AI commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

@copilot Here are some states transitions to recheck:

...

Rechecked and confirmed in a509c79: tests cover all requested transitions in sqlite-store-session-state-transitionscreate -> active, active -> renewed, active -> expired, active -> terminated, and renewed -> active. No UI changes in this PR, so no screenshot applies.

Copilot AI and others added 19 commits May 18, 2026 23:58
Agent-Logs-Url: https://github.com/cl-sdk/wst/sessions/5cacea97-cbc9-4f52-bd3c-d719e4414e6b

Co-authored-by: diasbruno <362368+diasbruno@users.noreply.github.com>
Agent-Logs-Url: https://github.com/cl-sdk/wst/sessions/8fc39c89-35ef-4904-809d-a29da933048e

Co-authored-by: diasbruno <362368+diasbruno@users.noreply.github.com>
Agent-Logs-Url: https://github.com/cl-sdk/wst/sessions/8fc39c89-35ef-4904-809d-a29da933048e

Co-authored-by: diasbruno <362368+diasbruno@users.noreply.github.com>
@diasbruno
diasbruno force-pushed the copilot/create-sqlite-backed-session-store branch from a509c79 to 58126e5 Compare May 19, 2026 02:58
@diasbruno
diasbruno merged commit cdc39d5 into development May 19, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants