Skip to content

Button or link migrate #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: experimentWithTestTypescriptInstall
Choose a base branch
from
Open

Button or link migrate #3

wants to merge 3 commits into from

Conversation

clairep94
Copy link
Owner

@clairep94 clairep94 commented May 26, 2025 •
edited
Loading

Part 2 of proof of concept for migrating the client folder

  • Migrating an instance of a react file
  • Chose ButtonOrLink as this had a unit test already, so it was safer from silent regression

Changes:

  • Installed types for react-router-dom
  • Updated eslint for react typescript rules
  • Migrated ButtonOrLink to TS with updated JSDocs for more details on what the component does, as well as detailed JSDocs for the type ButtonOrLinkProps
  • Updated unit tests to check that it can render child components

@clairep94 clairep94 mentioned this pull request May 27, 2025
Open
7 tasks
@clairep94 clairep94 changed the base branch from develop to experimentWithTestTypescriptInstall May 27, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@clairep94