Skip to content

Conversation

@tamird
Copy link
Collaborator

@tamird tamird commented Dec 2, 2025

  • test: avoid relying on cwd
  • test: remove node-static dependency

@tamird
Copy link
Collaborator Author

tamird commented Dec 2, 2025

@HighCommander4 please see individual commits for an easier review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the node-static dependency from the test suite by implementing a custom static file server using Node's built-in http and fs modules. The changes also improve path handling by using path.resolve and path.join instead of relying on process.cwd(), making the tests more robust to execution context.

  • Replaces node-static with a custom HTTP server implementation for serving test assets
  • Updates path construction to use path.resolve and path.join for better cross-platform compatibility
  • Removes node-static and @types/node-static from package dependencies

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.

File Description
test/index.ts Replaces node-static with custom file server implementation and updates asset paths to use path module methods
package.json Removes node-static and @types/node-static from devDependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tamird tamird force-pushed the replace-node-static branch from 1b7942d to bc9c8be Compare December 2, 2025 15:57
@tamird tamird requested a review from Copilot December 2, 2025 15:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tamird tamird force-pushed the replace-node-static branch from bc9c8be to 4fa84cd Compare December 2, 2025 16:03
@tamird tamird requested a review from Copilot December 2, 2025 16:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tamird tamird force-pushed the replace-node-static branch 2 times, most recently from 7711115 to 4ddda02 Compare December 2, 2025 16:22
@HighCommander4 HighCommander4 removed their assignment Dec 2, 2025
@HighCommander4
Copy link
Contributor

(I think you meant to set me as reviewer rather than assignee.)

I've added this to my review queue, but just as a heads up, my queue of clangd-related reviews is very long at this point, and it may be quite a while before I get to this.

I've added some other reviewers as well (@hokein, @kadircet, @sam-mccall) and I would really appreciate some help with clangd reviews.

@tamird
Copy link
Collaborator Author

tamird commented Dec 2, 2025

Ack, thanks. As an aside, I requested codex access to clangd repositories, which among other things allows me to use @codex review comments to request AI reviews. They are pretty good. See if you can approve that request.

@HighCommander4
Copy link
Contributor

Ack, thanks. As an aside, I requested codex access to clangd repositories, which among other things allows me to use @codex review comments to request AI reviews. They are pretty good. See if you can approve that request.

I can't see the request. I think it requires admin permission which I don't have.

@tamird
Copy link
Collaborator Author

tamird commented Dec 6, 2025

Well, this is removing a test-only dependency, I'll go ahead and merge it; probably on Monday.

This library appears to be unmaintained and has transitive dependencies
that have security advisories, which in turn trigger security advisories
in https://github.com/clangd/node-clangd/security/dependabot. Thus
replace it with a tiny HTTP handler and remove the bad dependencies.
@tamird tamird force-pushed the replace-node-static branch from 4ddda02 to 446becc Compare December 8, 2025 19:33
@tamird tamird merged commit 446becc into master Dec 8, 2025
3 checks passed
@tamird tamird deleted the replace-node-static branch December 8, 2025 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants