Add option to delay reporting of diagnostics for configurable amount of time#898
Open
Iritscen wants to merge 4 commits intoclangd:masterfrom
Open
Add option to delay reporting of diagnostics for configurable amount of time#898Iritscen wants to merge 4 commits intoclangd:masterfrom
Iritscen wants to merge 4 commits intoclangd:masterfrom
Conversation
…fixed time has passed after user inactivty.
… removed variable in clangd-context.ts that's only needed for line-change diagnostic delay.
Author
|
Sorry for the delayed fix – I committed my code just as I was about to go away for a week, and only saw for the first time that it was breaking MockClangdContext when I issued the pull request, so I've finally just gotten the chance to fix that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See this comment on how the feature works. I did have to change the code a bit, after creating the branch which is linked in that comment, in order for it to work with the current codebase post-this commit, but it still fundamentally does the same thing, which is hold onto the diagnostics received from clangd until the user-configured time has elapsed. I'm new to this codebase and also not much of a TypeScript/JS user, so any and all feedback is welcome.
Addresses #262 and #843