Skip to content

Use github actions for windows #1845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 21, 2020
Merged

Use github actions for windows #1845

merged 2 commits into from
Apr 21, 2020

Conversation

pksunkara
Copy link
Member

No description provided.

@pksunkara pksunkara force-pushed the ci branch 9 times, most recently from f01794b to 348e478 Compare April 20, 2020 21:17
pksunkara
pksunkara commented Apr 20, 2020
View reviewed changes
pksunkara
pksunkara commented Apr 20, 2020
View reviewed changes
pksunkara
pksunkara commented Apr 20, 2020
View reviewed changes
@pksunkara pksunkara marked this pull request as ready for review April 20, 2020 22:28
CreepySkeleton
CreepySkeleton reviewed Apr 21, 2020
View reviewed changes
Copy link
Contributor

@CreepySkeleton CreepySkeleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But why do you want to move from azure to GA in the first place? Especially that Azure works OK and GA does not?

CreepySkeleton
CreepySkeleton approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@CreepySkeleton CreepySkeleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

bors bot added a commit that referenced this pull request Apr 21, 2020
@bors @pksunkara
Merge #1845
5d2e645 
1845: Use github actions for windows r=CreepySkeleton a=pksunkara



Co-authored-by: Pavan Kumar Sunkara <[email protected]>
@bors
Copy link
Contributor

bors bot commented Apr 21, 2020

Canceled.

CreepySkeleton
CreepySkeleton approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@CreepySkeleton CreepySkeleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing against, but we still see the whole bunch of the checks, nothing is hidden or something. What does it do?

@pksunkara
Copy link
Member Author

It's not about hiding the checks but it's about just have one status for all the checks which can be checked upon in bors.toml. Otherwise I would have to list all the individual checks:

"Tests (windows-latest, 1.40.0, i686-pc-windows-msvc, all)",
"Tests (windows-latest, 1.40.0, i686-pc-windows-msvc, none)",
...

@CreepySkeleton
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 21, 2020

Build succeeded:

@bors bors bot merged commit 857b440 into master Apr 21, 2020
@bors bors bot deleted the ci branch April 21, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CreepySkeleton CreepySkeleton CreepySkeleton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pksunkara @CreepySkeleton