Replace another sort_by call by a manual insertion with a binary_search#5879
Merged
epage merged 1 commit intoclap-rs:masterfrom Jan 9, 2025
Merged
Conversation
auto-merge was automatically disabled
January 9, 2025 17:47
Head branch was pushed to by a user without write access
1e0530b to
f71b41c
Compare
Contributor
Author
|
Argh, forgot to run the unit tests on the last change which changed the order of the results in a test for some reason. Will fix or revert to previous version. |
Turns out to be another win in case the suggestions feature is enabled Signed-off-by: Daniel Egger <daniel@eggers-club.de>
f71b41c to
4f448df
Compare
Contributor
Author
|
Okay, reverted back to previous version. Sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out to be another win by doing a manual insertion sort of the suggestion rather than using
sort_by.Before:
and after: