feat: add arg index to error context#5883
Closed
jordanjennings-mysten wants to merge 1 commit intoclap-rs:masterfrom
Closed
feat: add arg index to error context#5883jordanjennings-mysten wants to merge 1 commit intoclap-rs:masterfrom
jordanjennings-mysten wants to merge 1 commit intoclap-rs:masterfrom
Conversation
jordanjennings-mysten
force-pushed
the
add-arg-index-to-error-context
branch
from
8ab3e05 to
276c7e3
Compare
jordanjennings-mysten
force-pushed
the
add-arg-index-to-error-context
branch
from
276c7e3 to
3312cc5
Compare
Member
|
Per our CONTRIBUTING guide we should be closing out the design discussion in the issue first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds arg index to the error context, LMK if this seems like a reasonable approach. We would like to utilize this information to create "at line/character XYZ" style errors using miette.
related issue
#4948