test: Add unit test for fish env completer to clap_complete#6197
Merged
epage merged 1 commit intoclap-rs:masterfrom Dec 17, 2025
Merged
test: Add unit test for fish env completer to clap_complete#6197epage merged 1 commit intoclap-rs:masterfrom
epage merged 1 commit intoclap-rs:masterfrom
Conversation
2 tasks
devjgm
changed the title
epage
reviewed
Dec 17, 2025
Related to: clap-rs#6196 This PR adds a unit test showing the current behavior of the the Fish shell env completer, that quotes paths incorrectly when there are spaces in the path. The issue should be demonstrated in this PR, and a follow-up PR could have a fix for the issue.
devjgm
force-pushed
the
greg/fix-clap-completer-issue-with-fish
branch
from
becb097 to
d495145
Compare
devjgm
changed the title
devjgm
changed the title
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: #6196
This PR adds a unit test showing the current behavior of the the Fish shell env completer, that quotes paths incorrectly when there are spaces in the path. The issue should be demonstrated in this PR, and a follow-up PR could have a fix for the issue.