feat(derive): Support RFC 3681 default field values #6220
+140
−83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If you are looking to explore this being used in clap, I would recommend opening an issue for discussing the design. One important reason for being Issues-first is shown here where we have two different PRs for this and the conversation can be harder to follow as we go through PRs. Let's leave the PR for discussing the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept to demonstrate what supporting the language-level field defaults defined by RFC 3681 might look like.
The behavior implemented is that the language-level field default gets ignored if the existing
default_valueattribute is present. I haven't decided if that's optimal or not.It uses the
synversion from this PR: dtolnay/syn#1955