Fix holdReset glitches for async resets and add registerSyncReset (copy #3116)
#3145
+239
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aimed to address #3115
This updates the documentation of
holdResetto indicate the problems it has. It also gives a new functionstretchResetthat should have the correct behaviour but has slightly different timing characteristics so it's not a drop in replacement.I have marked the
holdResetfunction with a warning, I don't like it since now we introduce warning into our own project when exposing it and using it in tests. I also thought a deprecation pragma. Both have some implication as that requires a version bump according to haskell PVP specification.Still TODO:
This is an automatic copy of pull request #3116 done by [Mergify](https://mergify.com).