Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Feb 10, 2026

Aimed to address #3115

This updates the documentation of holdReset to indicate the problems it has. It also gives a new function stretchReset that should have the correct behaviour but has slightly different timing characteristics so it's not a drop in replacement.

I have marked the holdReset function with a warning, I don't like it since now we introduce warning into our own project when exposing it and using it in tests. I also thought a deprecation pragma. Both have some implication as that requires a version bump according to haskell PVP specification.

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files
  • Write test
  • Adjust doctest

This is an automatic copy of pull request #3116 done by [Mergify](https://mergify.com).

@mergify
Copy link
Contributor Author

mergify bot commented Feb 10, 2026

Cherry-pick of b1b1477 has failed:

On branch mergify/copy/1.8/pr-3116
Your branch is up to date with 'origin/1.8'.

You are currently cherry-picking commit b1b1477a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   changelog/2026-01-08T16_58_32+01_00_add_registerSyncReset
	new file:   changelog/2026-01-08T16_58_32+01_00_fix_holdreset
	modified:   clash-prelude/src/Clash/Explicit/Reset.hs
	modified:   tests/Main.hs
	new file:   tests/shouldwork/Signal/HoldResetAsync.hs
	new file:   tests/shouldwork/Signal/HoldResetSync.hs

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   clash-prelude/src/Clash/Signal.hs
	both modified:   tests/shouldwork/Signal/ResetGen.hs

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Feb 10, 2026
@rowanG077 rowanG077 force-pushed the mergify/copy/1.8/pr-3116 branch from 0a89c77 to 9bdf91a Compare February 10, 2026 08:33
for async resets

add `registerSyncReset`

(cherry picked from commit b1b1477)

# Conflicts:
#	clash-prelude/src/Clash/Signal.hs
#	tests/shouldwork/Signal/ResetGen.hs
@rowanG077 rowanG077 force-pushed the mergify/copy/1.8/pr-3116 branch from 9bdf91a to ae866c0 Compare February 10, 2026 08:44
@rowanG077 rowanG077 merged commit 95352c6 into 1.8 Feb 10, 2026
22 of 24 checks passed
@rowanG077 rowanG077 deleted the mergify/copy/1.8/pr-3116 branch February 10, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant