Open
Conversation
martijnbastiaan
force-pushed
the
workaround-ghc-typelits-extra-68
branch
from
66c02ba to
d5cdcd8
Compare
See clash-lang/ghc-typelits-extra#68 This currently breaks compiles over at `clash-cores`. See clash-lang/clash-cores#56.
martijnbastiaan
force-pushed
the
workaround-ghc-typelits-extra-68
branch
from
d5cdcd8 to
6dd26ef
Compare
rowanG077
reviewed
Jan 7, 2026
| (KnownNat dataWidth) => | ||
| (1 <= dataWidth) => | ||
| (1 <= headerBytes `DivRU` dataWidth) => | ||
| -- \| XXX: The 'Constraint' equality is there to work around |
Member
There was a problem hiding this comment.
I think this will force users to have both ((1 <= headerBytes DivRU dataWidth) ~ (() :: Constraint)) which is confusing. I think it's probably better to have a constraintImpliesUnitConstraint :: forall a. a => Dict (a ~ (() :: Constraint)) and apply that.
Member
Author
There was a problem hiding this comment.
Alright, makes sense to me
Member
Author
There was a problem hiding this comment.
I talked to Christiaan in the office btw, hence skipping the review. Glad you caught it though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See clash-lang/ghc-typelits-extra#68
This currently breaks compiles over at
clash-cores. See clash-lang/clash-cores#56.