Avalon-MM: use BitVectors and remove unused field#187
Draft
JvWesterveld wants to merge 2 commits intoclash-lang:mainfrom
Draft
Avalon-MM: use BitVectors and remove unused field#187JvWesterveld wants to merge 2 commits intoclash-lang:mainfrom
JvWesterveld wants to merge 2 commits intoclash-lang:mainfrom
Conversation
Which should be easier to work with (fever type coercions) than with the previous `Unsigned`.
Member
|
I didn't write it. But I expect |
Contributor
Author
|
Right, it indeed looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking changes.
Does anyone know what the unused field
fixedWaitTimethat's removed in the first commit was supposed to be used for?Perhaps I should also change the
irqListfield type over to BitVector.