Open
Conversation
martijnbastiaan
requested changes
May 2, 2023
We now have a fifo implementation that exposes metadata called `fifoWithMeta`. The previous implementation of `fifo` has been replaced with a new one. The only difference is that the new implementation does not implement bypassing when the fifo is empty.
lmbollen
force-pushed
the
change-fifo-implementation
branch
from
08a2f2b to
3feffee
Compare
Member
Couldn't the old implementation be adapted to export empty/full signals? As it stands users of |
lmbollen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now have a fifo implementation that exposes metadata called
fifoWithMeta. The previous implementation offifohas been replaced with a new one. The only difference is that the new implementation does not implement bypassing when the fifo is empty.