Merged
Conversation
Not sure what it was for. We can call mangled-symbols directly if it's really necessary (e.g. with --eval). Having this in there complicates process exit. Unnecessary cross cutting concerns shall die.
Throwing an exception makes it difficult on other threads than the main one - it throws an exception which is not caught, which does end the program but with a hard to understand error.
should cut down on the "unknown exception" crash messages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows
quitand friends to be called from threads other than the main one without causing one of those stupid "unknown exception" errors. While I was at it I fixed up our exceptions to actually bestd::exceptions, so uncaught exception bugs should be a little more scrutable.