Skip to content

Show coords in top left of plot (fixes #82) #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Peter9192 merged 3 commits into from
Apr 4, 2025
Merged

Show coords in top left of plot (fixes #82) #121

Peter9192 merged 3 commits into from
Apr 4, 2025

Conversation

@Peter9192
Copy link
Member

@Peter9192 Peter9192 commented Apr 3, 2025 •
edited
Loading

TODO:

  • Add formatting
  • Check what skewT should be rendering
  • Use proper variable name instead of x and y

sverhoeven
sverhoeven approved these changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@sverhoeven sverhoeven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me,

@Peter9192
Copy link
Member Author

Peter9192 commented Apr 4, 2025

Now skew-T plot renders correct value for temperature and pressure.

@Peter9192
Copy link
Member Author

Peter9192 commented Apr 4, 2025

I will merge this as is, later on we could change x/y to actual coordinates, but this is low prio.

@Peter9192 Peter9192 marked this pull request as ready for review April 4, 2025 09:59
@Peter9192 Peter9192 merged commit edf3e1f into main Apr 4, 2025
4 checks passed
@Peter9192 Peter9192 deleted the render-coords-82 branch April 4, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sverhoeven sverhoeven sverhoeven approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Peter9192 @sverhoeven